[Skiboot] [PATCH] cpu: Ensure no-return flag is updated for current cpu_thread

Stewart Smith stewart at linux.ibm.com
Wed Jul 11 15:07:28 AEST 2018

Vaibhav Jain <vaibhav at linux.ibm.com> writes:
> Presently in case a cpu_thread queues a non returning job on itself,
> the variable cpu_thread.job_has_no_return is never updated and other
> cpu_threads can still queue a job on it without triggering any
> warnings.
> So this patch updates __cpu_queue_job() to ensure that
> job_has_no_return is updated on the current cpu_thread before it
> branches to the job->func(). So if the current job is non-returning
> then other cpu_threads queuing a job on this cpu will trigger a
> warning. This should aid in debugging some skiboot deadlocks.
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
>  core/cpu.c | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, merged to master as of 8e61dfdb38652781cc49736eb64ff4f8e714690e
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list