[Skiboot] [PATCH v2] npu2: Use same compatible string for NVLink and OpenCAPI link nodes in device tree

Stewart Smith stewart at linux.ibm.com
Wed Jul 4 14:49:59 AEST 2018

Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> Currently, we distinguish between NPU links for NVLink devices and OpenCAPI
> devices through the use of two different compatible strings - ibm,npu-link
> and ibm,npu-link-opencapi.
> As we move towards supporting configurations with both NVLink and OpenCAPI
> devices behind a single NPU, we need to detect the device type as part of
> presence detection, which can't happen until well after the point where the
> HDAT or platform code has created the NPU device tree nodes. Changing a
> node's compatible string after it's been created is a bit ugly, so instead
> we should move the device type to a new property which we can add to the
> node later on.
> Get rid of the ibm,npu-link-opencapi compatible string, add a new
> ibm,npu-link-type property, and a helper function to check the link type.
> Add an "unknown" device type in preparation for later patches to detect
> device type dynamically.
> These device tree bindings are entirely internal to skiboot and are not
> consumed directly by Linux, so this shouldn't break anything (other than
> internal BML lab environments).
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Thanks, merged to master as of a36b40799055d0ff070f87376a486caed5c3a475
Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list