[Skiboot] [RFC PATCH] pflash: Print libflash error strings

Oliver oohall at gmail.com
Tue Feb 27 18:46:58 AEDT 2018

On Tue, Feb 27, 2018 at 5:50 PM, Cyril Bur <cyrilbur at gmail.com> wrote:
> On Tue, 2018-02-27 at 17:24 +1100, Stewart Smith wrote:
>> Oliver O'Halloran <oohall at gmail.com> writes:
>> > Seems like something we might want. Currently most errors just give a
>> > little bit of context and spit an error code at you which requires
>> > looking inside of libflash to work out the meaning of.
>> >
>> > Inspired-by: https://github.com/open-power/skiboot/issues/151
>> > Cc: cyrilbur at gmail.com
>> > Cc: ppaidipe at linux.vnet.ibm.com
>> this does look like something we want.
> I haven't had much of a look, something like this would be great
>> Why RFC?

Largely because it doesn't even try and address the libffs error codes
and I only did a half-assed pass over pflash to find places where we
were printing them. Odds are there are places in libflash that would
need fixing up too.

> Maybe because it breaks tests ;)

Hell I'm not even sure it compiles.


More information about the Skiboot mailing list