[Skiboot] [PATCH v2] core/init: Add ibm, processor-storage-keys property to /cpus DT node.

Thiago Jung Bauermann bauerman at linux.vnet.ibm.com
Tue Feb 27 02:47:16 AEDT 2018


Ram Pai <linuxram at us.ibm.com> writes:
> If it moves to any other place, the upstream kernel code will have to be
> modified. Will have to standardize this before 4.16 is released.
>
> My preference is to keep it in the same place as what phyp does.

Michael Ellerman <mpe at ellerman.id.au> writes:
>> The only open issue is where to put the property. Currently, the Linux
>> code only looks for it in nodes with device_type = "cpu". This patch
>> puts it in /cpus to avoid repeating the property in each CPU node, but
>> Michael Ellerman suggested putting it in the ibm,opal node instead.
>
> Hmm did I, probably :)
>
> It's annoying the way these properties get multiplied for each CPU, but
> for now we should probably just stick with tradition and put it in each
> CPU node.

I agree that it's better to do what pHyp does  here.

> Sorry to change my mind on that. Are you able to respin it with that
> change?

No problem. And no need to respin either. v1 of this patch still applies
cleanly and still works, as well.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center



More information about the Skiboot mailing list