[Skiboot] [PATCH] vas: Disable VAS/NX-842 on some P9 revisions

[Oliver]

On Thu, Feb 15, 2018 at 5:48 PM, Stewart Smith
<stewart at linux.vnet.ibm.com> wrote:
> Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com> writes:
>> Michael Neuling [mikey at neuling.org] wrote:
>>> > + * Return true for those revisions. Return false for others.
>>> > + */
>>> > +__attrconst inline bool vas_nx_disabled(void)
>>>
>>> Minor nit, can you make this vax_nx_enabled() and change the sex throughout the
>>> code.
>>
>> Sure. Here is the updated patch.
>>
>> ---
>> From 99ecaa18b50e5f43baa39a52336660e6e9a139d0 Mon Sep 17 00:00:00 2001
>> From: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
>> Date: Fri, 9 Feb 2018 11:21:30 -0800
>> Subject: [PATCH 1/1] vas: Disable VAS/NX-842 on some P9 revisions
>>
>> VAS/NX-842 are not functional on some P9 revisions, so disable them
>> in hardware and skip creating their device tree nodes.
>>
>> Since the intent is to prevent OS from configuring VAS/NX, we remove
>> only the platform device nodes but leave the VAS/NX DT nodes under
>> xscom (i.e we don't skip add_vas_node() in hdata/spira.c)
>>
>> Thanks to input from Michael Ellerman, Michael Neuling.
>>
>> Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
>> ---
>>
>> Changelog[v2]
>>       - [Michael Neuling]: Use "_enabled" in the interface name.
>>       - [Michael Ellerman, Sukadev]. Update function header comments.
>> ---
>>  hw/nx.c       |  6 ++++++
>>  hw/vas.c      | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++----
>>  include/vas.h |  1 +
>>  3 files changed, 58 insertions(+), 4 deletions(-)
>
> Thanks for this, merged to master as of
> 31e5e988632f6554f70ed3e4072aef4245ee7b73 and is present in v5.10-rc3

We probably want to backport this to 5.9.x too

>
>
> --
> Stewart Smith
> OPAL Architect, IBM.
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot