[Skiboot] [PATCH v3 05/10] npu2-opencapi: Configure NPU for OpenCAPI

Reza Arbab arbab at linux.vnet.ibm.com
Thu Feb 1 08:28:42 AEDT 2018


On Wed, Jan 31, 2018 at 08:34:45PM +1100, Andrew Donnellan wrote:
>diff --git a/include/npu2.h b/include/npu2.h
>index 94e537b..7b2b509 100644
>--- a/include/npu2.h
>+++ b/include/npu2.h
>@@ -138,6 +138,7 @@ struct npu2_dev {
>
> struct npu2 {
> 	uint32_t	index;
>+	struct dt_node	*dt_node;
> 	uint32_t	flags;
> 	uint32_t	chip_id;
> 	uint64_t	xscom_base;

I see this gets set in npu2_opencapi_probe(). It might save some future 
confusion to go ahead and set it in the npu2_probe() path now too.

Just a thought. With or without,

Acked-by: Reza Arbab <arbab at linux.vnet.ibm.com>

-- 
Reza Arbab



More information about the Skiboot mailing list