[Skiboot] [PATCH v3 02/10] npu2: Rework NPU data structures for OpenCAPI

Reza Arbab arbab at linux.vnet.ibm.com
Thu Feb 1 07:59:01 AEDT 2018


On Wed, Jan 31, 2018 at 08:34:42PM +1100, Andrew Donnellan wrote:
>Unlike NVLink, OpenCAPI registers a separate PHB for each device, in order
>to allow us to force Linux to use the correct MMIO windows for each NPU
>link. This requires some reworking of NPU data structures to account for
>the fact that a PHB could correspond to either an NPU (NVLink) or a single
>link (OpenCAPI).
>
>At some later point, we may want to rework the NVLink code to present a
>separate PHB per device in order to simplify this. For now, we split
>NVLink-specific device data into a separate struct in order to make it
>clear which fields are NVLink-only.

I suppose there's probably a way to accomplish this using a union within 
the struct, but this is simpler.

Acked-by: Reza Arbab <arbab at linux.vnet.ibm.com>

-- 
Reza Arbab



More information about the Skiboot mailing list