[Skiboot] [PATCH 03/13] hw/npu2: Move PHY/NTL/GENID BAR assignment to common code

Andrew Donnellan andrew.donnellan at au1.ibm.com
Fri Dec 14 16:35:18 AEDT 2018

On 14/12/18 3:53 pm, Alexey Kardashevskiy wrote:
> On 14/12/2018 02:18, Frederic Barrat wrote:
>> Le 12/12/2018 à 07:58, Andrew Donnellan a écrit :
>>> Assignment of PHY/NTL/GENID BARs is currently duplicated between NVLink
>>> and OpenCAPI. This is going to cause us particular issues later on
>>> when we
>>> implement support for mixed-mode setups with NVLink and OpenCAPI on the
>>> same NPU.
>>> Centralise the assignment of PHY/NTL/GENID BARs in common code.
>>> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
>>> ---
>> That one gave me a headache, mostly because I was not that familiar with
>> the bar setup on the nvlink side of things (and some bars are written
>> twice!). Hopefully we'll get another pair of eyes with a nvlink focus on
>> it.
> There are way too many changes for such a small commit log. There are
> actually 2 or 3 patches inside this one trying to get out, this is not
> bisecable at all :(

I put these together as one patch because there's a bunch of 
interdependencies here... there's a few bits I can split out easily so 
I'll do that in v2 but there will probably still be one big chunk for 
the big BAR assigning loop

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Skiboot mailing list