[Skiboot] [PATCH 06/13] hw/npu2: Rework npu2_add_interrupt_map() and skip non-NVLink devices

[Andrew Donnellan]

On 14/12/18 4:24 pm, Alexey Kardashevskiy wrote:
>>   		map[i + 4] = icsp; /* interrupt-parent */
>> -		map[i + 5] = p->base_lsi + (index * 2) + 1; /* NDL No-Stall Event */
>> +		map[i + 5] = p->base_lsi + (dev->brick_index * 2) + 1; /* NDL No-Stall Event */
> 
> 
> The comment in hw/npu2-common.c says "May be overridden by platform
> presence detection" about dev->brick_index initialization. And
> brick_index is initialized from link_index which is (as I figured out
> recently) not exactly the index into npu2::devices[]. So probably
> switching from npu2::devices[]'s index to dev->brick_index is the right
> move but please make it a separate patch for bisectability.

If you really want it in a separate patch I can do that but it's a very 
minor change, I will at least document it in the commit


-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited