[Skiboot] [PATCH 2/2] Remove skiboot 'trace' infrastructure
joel at jms.id.au
Wed Dec 12 15:06:58 AEDT 2018
On Wed, 12 Dec 2018 at 14:28, Stewart Smith <stewart at linux.ibm.com> wrote:
> Joel Stanley <joel at jms.id.au> writes:
> > This feature has bit rotted. For instance, the FSP TCE mapping was
> > broken in 2015 by commit f2a7a5c23d81 ("Move boot_tracebuf to BSS"),
> > and no one seems to have noticed.
> Oliver, you were showing signs in Slack of "volunteering" of becoming
> the maintainer of this stuff and cleaning up.
> Your thoughts on ripping it out for the moment versus just ripping out
> the FSP bit in patch 1?
The linker script bit is a noop, as f2a7a5c23d81 stopped using the
section defined in the linker script.
The comment about FSP was from map_debug_areas in
platforms/ibm-fsp/common.c. I assumed that Ben had the traces in a
defined area for it to be mapped properly. But I could be interpreting
the intent of that wrong.>
> Stewart Smith
> OPAL Architect, IBM.
More information about the Skiboot