[Skiboot] [PATCH v2 1/8] opal: Update opal_del_host_sync_notifier() to accept 'void *data'

christophe lombard clombard at linux.vnet.ibm.com
Tue Dec 11 00:09:12 AEDT 2018

Le 09/12/2018 à 15:17, Vaibhav Jain a écrit :
> Current implementation of opal_del_host_sync_notifier() will only
> delete the first entry of the 'notify' callback found from opal_syncers
> list irrespective of the 'data' of list-node. This is problematic when
> multiple notifiers with same callback function but different 'data'
> are registered. In this case when the cleanup code will call
> opal_del_host_sync_notifier() it cannot be sure if correct opal_syncer
> is removed.
> Hence this patch updates the function to accept a new argument named
> 'void *data' which is then used to iterates over the opal_syncers list
> and only remove the first node node having the matching value for
> 'notify' callback as 'data'.
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
> Change-log:
> v2: Instead of introducing a new function, update the existing
>      function opal_del_host_sync_notifier() to accept 'void *data' [Vasant]
> ---

Reviewed-by: Christophe Lombard <clombard at linux.vnet.ibm.com>

More information about the Skiboot mailing list