[Skiboot] [PATCH 2/3] skiboot: Enable opal calls to init/start/stop IMC Trace mode

[Stewart Smith]

Madhavan Srinivasan <maddy at linux.vnet.ibm.com> writes:
> On 04/10/18 11:39 AM, Anju T Sudhakar wrote:
>> Patch to enhance the imc opal call to support and handle trace_imc mode.
>>
>> To initialize the trace-mode, TRACE_IMC_SCOM value is written to
>> TRACE_IMC_ADDR of the respective core.
>>
>> TRACE_IMC_SCOM is a 64bit value, and each bit represent the following:
>> 0:1       : SAMPSEL
>> 2:33      : CPMC_LOAD
>> 34:40     : CPMC1SEL
>> 41:47     : CPMC2SEL
>> 48:50     : BUFFERSIZE
>> 51:63      : RESERVED
>> For the nonce the value for TRACE_IMC_SCOM is hard coded.
>> During initialization htm_mode is disabled, and enabled only at start.
>>
>> The opal calls to start/stop the counters, will write CORE_IMC_HTM_MODE_ENABLE/
>> CORE_IMC_HTM_MODE_DISABLE respectively to the htm_scom_index of the desired
>> cores.
>>
>> Additional switch cases are added to the current opal calls to start/stop
>> the counters for trace-mode.
>
>
> May not be a critical thing, but as a follow up patch later point
> can you also update the imc documentation and imc devicetree tree file
> about the trace mode.Apart from that patch looks fine to me

I'd like to have the documentation in place for device tree changes
before merging.

-- 
Stewart Smith
OPAL Architect, IBM.