[Skiboot] [RFC PATCH skiboot] hmi/npu2: Print register names in HMI dump

Stewart Smith stewart at linux.ibm.com
Mon Dec 10 16:04:21 AEDT 2018


Alexey Kardashevskiy <aik at ozlabs.ru> writes:
> This prints register names and skips zero values which should improve
> readability in 2018. Done by regexps.

Looks like an improvement over my terrible hastily-written patch. Any
reason why I shouldn't merge?

> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
> ---
>
> I am pretty sure there is a better way of doing things and Stack==0x50/block=0x1
> should already be defined somewhere by now but I could not spot them, where are they?
> The offset also seems to be calculatable but I do not see that we do
> this anywhere.

Alistair, Reza? I think I looked for the same thing way back.


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list