[Skiboot] [PATCH] phb4: Fix typo in disable lane eq code

Michael Neuling mikey at neuling.org
Wed Aug 29 15:18:58 AEST 2018


In this commit
  commit 737c0ba3d72b8aab05a765a9fc111a48faac0f75
  Author: Michael Neuling <mikey at neuling.org>
  Date:   Thu Feb 22 10:52:18 2018 +1100
  phb4: Disable lane eq when retrying some nvidia GEN3 devices

We made a typo and set PH2 twice. This fixes it.

It worked previously as if only phase 2 (PH2) is set it, skips phase 2
and phase 3 (PH3).

Reported-by: Meng Li <shlimeng at cn.ibm.com>
Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index d1245dce5a..04b5f0bd96 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -4868,7 +4868,7 @@ static void phb4_init_hw(struct phb4 *p)
 		/* Read modify write and set to 2 bits */
 		PHBDBG(p, "LINK: Disabling Lane EQ\n");
 		val = in_be64(p->regs + PHB_PCIE_DLP_CTL);
-		val |= PHB_PCIE_DLP_CTL_BYPASS_PH2 | PHB_PCIE_DLP_CTL_BYPASS_PH2;
+		val |= PHB_PCIE_DLP_CTL_BYPASS_PH2 | PHB_PCIE_DLP_CTL_BYPASS_PH3;
 		out_be64(p->regs + PHB_PCIE_DLP_CTL, val);
 	}
 
-- 
2.17.1



More information about the Skiboot mailing list