[Skiboot] [PATCH] phb4: Enable PHB MMIO-0/1 Bars only when mmio window exists

Vaibhav Jain vaibhav at linux.ibm.com
Thu Aug 23 19:40:21 AEST 2018

Thanks for reviewing the patch Oliver

Oliver <oohall at gmail.com> writes:

> In what circumstances do we have PHBs that aren't in the phys map?
AFAIK None right now. But still theres certainly a possibility of having
slots that only supports cards with one of two 64/32 bit mmio windows.

> I think you can remove just this line and drop the rest of the changes
> in the patch. I'd rather we kept the XSCOM writes here so that we know
> the BAR and MASK registers are explicitly set to zero even when the
> BAR is disabled.
Thanks for the suggestion. I will send a v2 incorporating this change.

Vaibhav Jain <vaibhav at linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.

More information about the Skiboot mailing list