[Skiboot] [PATCH 1/2] i2c: Fix multiple-enqueue of the same request on NACK

Stewart Smith stewart at linux.ibm.com
Thu Aug 16 19:26:26 AEST 2018


Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> i2c_request_send() will retry the request if the error is a NAK,
> however it forgets to clear the "ud.done" flag. It will thus
> loop again and try to re-enqueue the same request causing internal
> request list corruption.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  core/i2c.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Cheers, series merged as of:
master ef79d0370737130256168d20a9bf40f06001af88
6.0.x 9844f12ea28eee7c8d07c76043b5fdb170d6cd6a

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list