[Skiboot] [PATCH] capp: Fix the capp recovery timeout comparison

Stewart Smith stewart at linux.ibm.com
Thu Aug 16 19:19:37 AEST 2018

Vaibhav Jain <vaibhav at linux.ibm.com> writes:
> The current capp recovery timeout control loop in
> do_capp_recovery_scoms() uses a wrong comparison for return value of
> tb_compare(). This may cause do_capp_recovery_scoms() to report an
> timeout earlier than the 168ms stipulated time.
> The patch fixes this by updating the loop timeout control branch in
> do_capp_recovery_scoms() to use the correct enum tb_cmpval.
> Cc: Stable #6.0+
> Fixes: 09b853cae0aa0("capi: Poll Err/Status register during CAPP
> recovery")
> Reported-by: Frederic Barrat <fbarrat at linux.vnet.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav at linux.ibm.com>
> ---
>  hw/phb4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, merged:
master ec954f764efe064d7fc99e8a21a0ebdb7b8a3c91
6.0.x 509d687c96234e95e023d810e02cdadf56d1b24f

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list