[Skiboot] [PATCH v4 15/18] fadump: Send OPAL relocated base address to SBE

[Vasant Hegde]

On 08/07/2018 01:32 PM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> OPAL relocates itself during boot. During memory preserving IPL hostboot needs
>> to access relocated OPAL to get MDST, MDDT tables. Hence send relocated base
>> address to SBE via 'stash MPIPL config' chip-op. During next IPL SBE will send
>> stashed data to hostboot... so that hostboot can access these data.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> ---

.../...

>> +static void p9_sbe_stash_chipop_resp(struct p9_sbe_msg *msg)
>> +{
>> +	int rc = p9_sbe_get_primary_rc(msg->resp);
>> +	struct p9_sbe *sbe = (void *)msg->user_data;
>> +
>> +	if (rc == SBE_STATUS_PRI_SUCCESS) {
>> +		prlog(PR_DEBUG, "Sent stash MPIPL config [chip id =0x%x]\n",
>> +		      sbe->chip_id);
>> +	} else {
>> +		prlog(PR_DEBUG, "Failed to send stash MPIPL config "
>> +		      "[chip id = 0x%x, rc = %d]\n", sbe->chip_id, rc);
> 
> Should this be PR_ERR in the case where hostboot told us mpipl is supported?
> 

Agree. Will fix in v5.

-Vasant