[Skiboot] [PATCH] pci: Clarify power down logic

Stewart Smith stewart at linux.ibm.com
Thu Aug 2 16:49:59 AEST 2018


"Oliver O'Halloran" <oohall at gmail.com> writes:
> Currently pci_scan_bus() unconditionally calls pci_slot_set_power_state()
> when it's finished scanning a bus. This is one of those things that
> makes you go "WHAT?" when you first see it and frankly the skiboot PCI
> code could do with less of that.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  core/pci.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Not being something that makes you go "WHAT?" is totally against a bunch
of our PCI code, but I'll make an exception this time :)

Merged to master as of 7a311b9dec275522d3479e019354913553b1f5bc

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list