[Skiboot] [PATCH] hw/phb4: Use local_alloc for phb4 structures

Stewart Smith stewart at linux.ibm.com
Thu Aug 2 16:42:59 AEST 2018

"Oliver O'Halloran" <oohall at gmail.com> writes:
> Struct phb4 is fairly heavyweight at 283664 bytes. On systems with
> 6x PHBs per socket this results in using 3.2MB of heap space the PHB
> structures alone. This is a fairly large chunk of our 12MB heap and
> on systems with particularly large PCIe topologies, or additional
> PHBs we can fail to boot because we cannot allocate space for the
> FDT blob.
> This patch switches to using local_alloc() for the PHB structures
> so they don't consume too large a portion of our 12MB heap space.
> Signed-off-by: Ryan Grimm <grimm at linux.vnet.ibm.com>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  hw/phb4.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Yeah, I think this ends up making sense.

I wonder what crazy "particularly large PCIe topologies" Ryan has been
playing with...

Merged to master as of 7a7ff2d6281fa7c4d90c836144f9c451427ecd25

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list