[Skiboot] [PATCH] opal-prd: Fix opal-prd crash

Stewart Smith stewart at linux.ibm.com
Thu Aug 2 16:41:14 AEST 2018

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> Presently callback function from HBRT uses r11 to point to target function
> pointer. r12 is garbage. This works fine when we compile with "-no-pie" option
> (as we don't use r12 to calculate TOC).
> As per ABIv2 : "r12 : Function entry address at global entry point"
> With "-pie" compilation option, we have to set r12 to point to global function
> entry point. So that we can calculate TOC properly.
> Crash log without this patch:
>   opal-prd[2864]: unhandled signal 11 at 0000000000029320 nip 00000 00102012830 lr 0000000102016890 code 1
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> CC: Jeremy Kerr <jk at ozlabs.org>
> CC: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  external/opal-prd/thunk.S | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

THanks! Merged to master as of ff576aa8187b47f61f902b6a097693d00c937d4c

Is this something that should go to stable?

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list