[Skiboot] [RFC PATCH] phb4: Make verbose EEH output less verbose

Stewart Smith stewart at linux.ibm.com
Wed Aug 1 17:20:12 AEST 2018


"Oliver O'Halloran" <oohall at gmail.com> writes:
> Each PHB4 component has a error status register and a set of
> component-specific registers that describe that error in more detail.
> If the status register of a component has no bits set there's not much
> point in dumping the error detail registers.
>
> This patch modifies the verbose EEH dumping code so that it only
> dumps the error registers of a component if there are bits set in the
> error status register of that component. This limits the output to the
> registers that are actually relevant to the error that occured which
> makes interpreting the dumps slightly easier.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
> I've been using this in my debug builds for a while, but I'm not sure
> if it's a great idea since sometimes other people want to full dump.
> It's probably fine...

It does look probably fine. Maybe Ben or Russell has thoughts?

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list