[Skiboot] [PATCH v2 2/5] phb4: Track PEC index in dt and phb4 struct

[Stewart Smith]

Reza Arbab <arbab at linux.ibm.com> writes:
> On Tue, Jul 31, 2018 at 01:26:06PM +1000, Stewart Smith wrote:
>>Reza Arbab <arbab at linux.ibm.com> writes:
>>> diff --git a/hw/phb4.c b/hw/phb4.c
>>> index a3aa8b8..39962ca 100644
>>> --- a/hw/phb4.c
>>> +++ b/hw/phb4.c
>>> @@ -5311,6 +5311,7 @@ static void phb4_create(struct dt_node *np)
>>>  	/* Populate base stuff */
>>>  	p->index = dt_prop_get_u32(np, "ibm,phb-index");
>>>  	p->chip_id = dt_prop_get_u32(np, "ibm,chip-id");
>>> +	p->pec = dt_prop_get_u32(np, "ibm,phb-pec-index");
>>>  	chip = get_chip(p->chip_id);
>>>  	p->regs = (void *)dt_get_address(np, 0, NULL);
>>>  	p->int_mmio = (void *)dt_get_address(np, 1, NULL);
>>
>>can you please also update doc/device-tree/ as to when this came in and
>>what it is?
>
> There isn't really any existing documentation for me to update. I can 
> add a "ibm,phb-pec-index" line to the example dts node in 
> doc/device-tree/pci.rst, but that's all I found.
>
> Would that be okay?

Yeah, and add when it started appearing and so tools should have a safe
default if the property isn't there.

-- 
Stewart Smith
OPAL Architect, IBM.