[Skiboot] [PATCH] mambo: disable OPAL_SIGNAL_SYSTEM_RESET

Nicholas Piggin npiggin at gmail.com
Wed Aug 1 12:52:12 AEST 2018

On Thu, 26 Jul 2018 18:03:50 +1000
Stewart Smith <stewart at linux.ibm.com> wrote:

> Nicholas Piggin <npiggin at gmail.com> writes:
> > mambo does not deliver system reset interrupts correctly (details in
> > the added comment), so disable it for now.
> >
> > Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> > --
> >
> > This feature was useful for developing the NMI IPI system in Linux,
> > but now it's somewhat working, and we've got OPAL_SIGNAL_SYSTEM_RESET
> > implemented on real hardware (and equivalent hypercall for QEMU
> > guests), it is less important now. It's annoing because it causes
> > breaking to xmon to usually often crash the kernel in an SMP sim.  
> (looking back at patches I've neglected in patchwork as I have a notmuch
> query for that now)
> I'm interested in another alternative as we do have stupid unittests for
> part of this code that is nice to have work.
> I guess we could look at what idle states are enabled, and for the unit
> tests, just enable none of them?

Yeah that could work for unit tests. One day if we get mambo fixed we
could turn it back on too. I'll have to get back to looking at that,
but I've had enough system reset problems for the moment :) The mambo
devs are busy with other things too I think.


More information about the Skiboot mailing list