[Skiboot] [PATCH] hdata/spira: be32_to_cpu() doesn't work on 8bits

Oliver oohall at gmail.com
Thu Sep 28 17:03:12 AEST 2017


On Thu, Sep 28, 2017 at 4:39 PM, Stewart Smith
<stewart at linux.vnet.ibm.com> wrote:
> Sparse warning:
> hdata/spira.c:1458:41: warning: incorrect type in argument 1 (different base types) expected restricted beint32_t [usertype] be_val got unsigned char const [unsigned] [usertype] link_speed
>
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  hdata/spira.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hdata/spira.c b/hdata/spira.c
> index 07d172b30afe..a153fe0b104c 100644
> --- a/hdata/spira.c
> +++ b/hdata/spira.c
> @@ -1455,7 +1455,7 @@ static void add_npu(struct dt_node *xscom, const struct HDIF_array_hdr *links,
>                 if (size <= 0x24)
>                         continue;
>
> -               switch (be32_to_cpu(link->link_speed)) {
> +               switch (link->link_speed) {

Ah yeah, that used to be a uint32. It got changed at the last minute
and I forgot to update that.

Reviewed-by: Oliver O'Halloran <oohall at gmail.com>


More information about the Skiboot mailing list