[Skiboot] [PATCH] hdata/i2c: hdat_i2c_labels and hdat_i2c_devs should be static

Stewart Smith stewart at linux.vnet.ibm.com
Thu Sep 28 16:43:28 AEST 2017


Silences sparse warnings:
hdata/i2c.c:103:23: warning: symbol 'hdat_i2c_labels' was not declared. Should it be static?
hdata/i2c.c:93:22: warning: symbol 'hdat_i2c_devs' was not declared. Should it be static?

Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
---
 hdata/i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hdata/i2c.c b/hdata/i2c.c
index 9de6aa4a7832..c7f38e98d9e7 100644
--- a/hdata/i2c.c
+++ b/hdata/i2c.c
@@ -90,7 +90,7 @@ struct hdat_i2c_type {
 	const char *compat;
 };
 
-struct hdat_i2c_type hdat_i2c_devs[] = {
+static struct hdat_i2c_type hdat_i2c_devs[] = {
 	/* XXX: Please verify that all VPD EEPROMs are of this type */
 	{ 0x2, "eeprom", "atmel,24c128" }
 };
@@ -100,7 +100,7 @@ struct hdat_i2c_label {
 	const char *label;
 };
 
-struct hdat_i2c_label hdat_i2c_labels[] = {
+static struct hdat_i2c_label hdat_i2c_labels[] = {
 	{ 0x1, "9551-led-controller" },
 	{ 0x2, "seeprom" },
 	{ 0x5, "module-vpd" },
-- 
2.13.5



More information about the Skiboot mailing list