[Skiboot] [PATCH 1/2] opal-prd: Fix occ_reset call
stewart at linux.vnet.ibm.com
Thu Sep 28 13:19:19 AEST 2017
Daniel M Crowell <dcrowell at us.ibm.com> writes:
> Seems fine (though I don't really have the context of what function this
> is. (I'm not fluent in patch reviews, not sure how you understand
> anything with so little context....)
A bunch of code context can be just kept in the brain (it goes alongside
the ego, both take up a lot of room :) - but the other half is just
applying the patches and looking at the result - i'll freely pipe to
'git am -s' when doing close review - build, look, etc. Of course, that
requires a sane mail client, which certainly isn't the IBM default.
OPAL Architect, IBM.
More information about the Skiboot