[Skiboot] [PATCH] phb4: Update link training documentation

Michael Neuling mikey at neuling.org
Thu Sep 21 17:23:18 AEST 2017


We added degraded link retries in:
   3f936bae97 phb4: Retrain link if degraded
but forgot to update the documentation.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/phb4.c b/hw/phb4.c
index 48ea4bd50c..aea67b1afd 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -82,6 +82,14 @@
  *   o Once we leave here, much harder to recover from errors
  *
  * Step 9:
+ * - Check for optimised link for directly attached devices:
+ *   o Wait for CRS (so we can read device config space)
+ *   o Check chip and device are in whitelist. if not, Goto Step 10
+ *   o If trained link speed is degraded, retry ->  Goto Step 2
+ *   o If trained link width is degraded, retry -> Goto Step 2
+ *   o If still degraded after 3 retries. Give up, Goto Step 10.
+ *
+ * Step 10:
  *  - PHB good, start probing config space.
  *    o core/pci.c: pci_reset_phb() -> pci_scan_phb()
  */
-- 
2.11.0



More information about the Skiboot mailing list