[Skiboot] [PATCH] blocklevel_info: Refactor the passing of output data

Stewart Smith stewart at linux.vnet.ibm.com
Thu Sep 21 12:23:10 AEST 2017


Cyril Bur <cyrilbur at gmail.com> writes:
> On Mon, 2017-08-28 at 21:19 -0700, William A. Kennington III wrote:
>> This changes refactors all of the output variables from flash_get_info
>> into a new output struct. Callers now supply the info struct, and always
>> get all of the info with each call. There are never any allocations done
>> by this function so it shouldn't be much slower to always populate all
>> of the information.
>> 
>
> Hi William,
>
> As nice as this refactor is (thanks for the effort!), unfortunately
> we're a bit stuck with the interface as is, both openbmc and petitboot
> projects link against a dynamic libflash.

We can always bump the .so version and they can update asynchronously.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list