[Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api

Balbir Singh bsingharora at gmail.com
Wed Sep 20 15:54:04 AEST 2017

On Wed, 20 Sep 2017 14:27:16 +1000
Stewart Smith <stewart at linux.vnet.ibm.com> wrote:

> Akshay Adiga <akshay.adiga at linux.vnet.ibm.com> writes:
> > p9_stop_api's are used to set SPR state on a core wakeup form a  deeper
> > low power state. p9_stop_api uses  low level platform formware and
> > self-restore microcode to restore the sprs to requested values.
> >
> > Code is taken from :
> > https://github.com/open-power/hostboot/tree/master/src/import/chips/p9/procedures/utils/stopreg  
> So, this introduces at least one warning from Coverity.
> Can you head to https://scan.coverity.com/projects/open-power-skiboot
> and sign up/request access so I can assign it to you?
> we probably need to push the fixes upstream to hostboot too.

The warnings seem to indicate a condition can never be met,
they seem reasonable enough that we can remove some dead-code.

Balbir Singh.

More information about the Skiboot mailing list