[Skiboot] [PATCH] capi: CAPP recovery

[christophe lombard]

Le 18/09/2017 à 08:13, Vaibhav Jain a écrit :
> Hi Christophe,
>
> Minor review comments:
>
> Christophe Lombard <clombard at linux.vnet.ibm.com> writes:
>> +
>> +	xscom_read(p->chip_id, CAPP_ERR_STATUS_CTRL + offset, &reg);
>> +	reg &= ~(PPC_BIT(0) | PPC_BIT(1));
>> +	xscom_write(p->chip_id, CAPP_ERR_STATUS_CTRL + offset, reg);
> Please use xscom_write_mask instead.

I would prefer keep this method, because it's similar compared what we 
have on phb3.

>>   	/* Transport Control Register */
>> @@ -3532,6 +3555,7 @@ static void phb4_init_capp_regs(struct phb4 *p)
>>   		reg |= PPC_BIT(11); /* Set CI Store Buffer Threshold=5 */
>>   		reg |= PPC_BIT(13); /* Set CI Store Buffer Threshold=5 */
>>   	}
>> +	reg |= PPC_BIT(15);
>>   	reg &= ~PPC_BITMASK(14, 17); /* Set Max LPC CI store buffer to zeros */
> And mask is resetting the BIT(15).

correct.

> Also should field be set to b0101 as
> per workbook.

You are right: b’0101’ = use 6 buffers, but we follow Oren's init.

#Set Max LPC CI store buffer to zeros - bits[14:17] = 0
putscom pu 0401081C  $2 -ib 14 4 0000