[Skiboot] [PATCH v3 0/3] npu2: Hook up data link interrupts

Stewart Smith stewart at linux.vnet.ibm.com
Wed Sep 13 17:06:51 AEST 2017

I want to hold this up as an example of series cover letters and commit

Sam Bobroff <sam.bobroff at au1.ibm.com> writes:
> [Note: Here is v3, which just has a few documentation fixes.]
> Here's a patch to configure the NPU2 to generate XIVE interrupts and pass the
> "recoverable data link" (also called "No-Stall") interrupts to Linux via
> emulated PCI devices.
> Because the emulated devices were already being created, it consists mostly of
> acquiring a XIVE trigger page, writing it's address into a register in the NPU2
> and creating the interrupt mapping properties in the device tree.
> I've also added a new byte to the vendor capabilities section of the emulated
> PCI devices; writes to it are passed through to the NPU2_MISC_IRQ_REQUEST
> register where they cause the device to trigger an interrupt. It's not perfect,
> because writing to that capability on two devices at once can cause one of the
> interrupts to be lost (because of my simplistic implementation) but it can be
> useful for testing.
> I have a simple PCI kernel driver that can be used to access that capability
> via some debugfs files. Would it be useful to put it somewhere?

I'd be happy to have it in external/

We could probably have it all live in op-test and have various kernels
and kernel drivers for testing, but for the moment, external/ would be fine.

Series Merged to master as of 9817c9e29b6fe00daa3a0e4420e69a97c90eb373

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list