[Skiboot] [PATCH 5/6] phb4: Make link retries a #define

Michael Neuling mikey at neuling.org
Tue Sep 12 14:56:18 AEST 2017


Make link retries a #define rather than open coding it in the PHB4
init code.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c      | 2 +-
 include/phb4.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index b8d87062d3..8c24238f8e 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2800,7 +2800,7 @@ static struct pci_slot *phb4_slot_create(struct phb *phb)
 	slot->ops.hreset		= phb4_hreset;
 	slot->ops.freset		= phb4_freset;
 	slot->ops.creset		= phb4_creset;
-	slot->link_retries		= 3;
+	slot->link_retries		= PHB4_LINK_LINK_RETRIES;
 
 	return slot;
 }
diff --git a/include/phb4.h b/include/phb4.h
index 503d3f1467..6f865b6e1c 100644
--- a/include/phb4.h
+++ b/include/phb4.h
@@ -214,6 +214,7 @@ struct phb4_err {
 	uint32_t err_bit;
 };
 
+#define PHB4_LINK_LINK_RETRIES		3
 /* Link timeouts, increments of 10ms */
 #define PHB4_LINK_ELECTRICAL_RETRIES	100
 #define PHB4_LINK_WAIT_RETRIES		200
-- 
2.11.0



More information about the Skiboot mailing list