[Skiboot] [PATCH v3 01/13] xive: Remove useless memory barriers in VP/EQ inits

Benjamin Herrenschmidt benh at kernel.crashing.org
Sun Sep 10 17:35:23 AEST 2017


We no longer update "live" memory structures, we use a temporary
copy on the stack and update the actual memory structure using
the cache watch, so those barriers are pointless.

Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
---
 hw/xive.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/xive.c b/hw/xive.c
index e478efc1..fb9257e3 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -887,7 +887,6 @@ static void xive_init_default_vp(struct xive_vp *vp,
 	 */
 	vp->w1 = (eq_blk << 28) | eq_idx;
 	vp->w5 = 0xff000000;
-	lwsync();
 	vp->w0 = VP_W0_VALID;
 }
 
@@ -903,7 +902,6 @@ static void xive_init_emu_eq(uint32_t vp_blk, uint32_t vp_idx,
 	eq->w6 = SETFIELD(EQ_W6_NVT_BLOCK, 0ul, vp_blk) |
 		SETFIELD(EQ_W6_NVT_INDEX, 0ul, vp_idx);
 	eq->w7 = SETFIELD(EQ_W7_F0_PRIORITY, 0ul, prio);
-	eieio();
 	eq->w0 = EQ_W0_VALID | EQ_W0_ENQUEUE |
 		SETFIELD(EQ_W0_QSIZE, 0ul, EQ_QSIZE_64K) |
 		EQ_W0_FIRMWARE;
-- 
2.13.5



More information about the Skiboot mailing list