[Skiboot] [PATCH] capi: Mask Psl Credit timeout error for P9

Stewart Smith stewart at linux.vnet.ibm.com
Thu Sep 7 16:08:22 AEST 2017

Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> On 05/09/17 21:45, Stewart Smith wrote:
>> This looks like a prime candidate for xscom_write_mask() that Alistair
>> introduced in:
>> commit e3f7d42c77bfc3b899d3d636b372e1292b790656
>> Author: Alistair Popple <alistair at popple.id.au>
>> Date:   Fri Aug 4 14:15:19 2017 +1000
>>      xscom: Add xscom_write_mask() function
>>      It is common for xscom registers to only contain specific bit fields that
>>      need to be modified without altering the rest of the register. This adds a
>>      convenience function to perform xscom read-modify-write operations under a
>>      mask.
> Hmm, I wonder if Coccinelle could help here...

Yeah, it could. I've started to poke at it a bit more, but I'm not
convinced I would get it right for
not-directly-copying-and-hacking-a-trivial-example yet :)

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list