[Skiboot] [PATCH 00/25] Checkpatch fixes

Michael Neuling mikey at neuling.org
Tue Sep 5 16:41:41 AEST 2017


On Tue, 2017-09-05 at 15:51 +1000, Joel Stanley wrote:
> Hi Stewart,
> 
> In an effort to game the commit numbers I have run checkpatch against the hw
> directory of skiboot. Please consider merging this series to fix the
> whitespace
> issues uncovered.
> 
> There are to non-whitespace changes which remove the unnecessary
> initialisation
> of static variables.

"Unfortunately I can't fault this."

Reviewed-by: Michael Neuling <mikey at neuling.org>

> Cheers,
> 
> Joel
> 
> Joel Stanley (25):
>   hw/bt: Remove space before tab in comment
>   hw/bt: Add space between while and (
>   hw/cec: Remove space before tab in comment
>   hw/centaur: Remove space before tab in comment
>   hw/centaur: Fix whitespace around comment
>   hw/chiptod: Remove space before tab in comment
>   hw/chiptod: Put a space after comma in arguments
>   hw/chiptod: Fix dt props to include comma before string
>   hw/chiptod: have a space between while and open paren
>   hw/chiptod: Fix tabs in opal_resync_timebase
>   hw/fake-nvram: Fix space between if and open paren
>   hw/fake-rtc: Remove space before tab in comment
>   hw/fake-nvram: Remove space before tab in comment
>   hw/fsi-master: Remove space before tab in comment
>   hw/homer.c: Remove space before tab in comment
>   hw/lpc: Fix tabs in base definitions
>   hw/fsi-master: Fix whitespace before mfsi_opb_write calls
>   hw/fsi-master: Fix other coding whitespace issues
>   hw/fsi-master: Add tabs before comment strings
>   hw/gx: Remove space before tab in comment
>   hw/gx: Add space between switch and open paren
>   hw/fake-nvram: Remove init of static variable to null
>   hw/bt: Remove init of static variable to false
>   hw/chiptod: Fix strange indentation in chiptod_probe
>   hw/chiptod: Fix indentation in opal_resync_timebase
> 
>  hw/bt.c         |  6 +++---
>  hw/cec.c        |  2 +-
>  hw/centaur.c    | 12 ++++++------
>  hw/chiptod.c    | 48 ++++++++++++++++++++++++------------------------
>  hw/fake-nvram.c | 10 +++++-----
>  hw/fake-rtc.c   |  2 +-
>  hw/fsi-master.c | 32 ++++++++++++++++----------------
>  hw/gx.c         |  8 ++++----
>  hw/homer.c      |  2 +-
>  hw/lpc.c        |  8 ++++----
>  10 files changed, 65 insertions(+), 65 deletions(-)
> 


More information about the Skiboot mailing list