[Skiboot] [PATCH 1/5] hdata: add secure and trusted boot ntuple to SPIRA-H/S

[Claudio Carvalho]

On 01/09/2017 01:24, Oliver wrote:
> On Thu, Aug 31, 2017 at 5:42 PM, Claudio Carvalho
> <cclaudio at linux.vnet.ibm.com> wrote:
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> + * implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +
>> +#ifndef pr_fmt
>> +#define pr_fmt(fmt) "HDAT TPMREL: " fmt
> Just make this TPMREL: or something. The bits of skiboot that are
> inside the HDAT parser are clearly marked already.
I will do that.

>
>> +#endif
>> +
>> +#include <skiboot.h>
>> +
>> +#include "spira.h"
>> +#include "hdata.h"
>> +#include "hdif.h"
>> +
>> +void node_stb_parse(void)
>> +{
>> +       struct HDIF_common_hdr *hdif_hdr;
>> +
>> +       hdif_hdr = get_hdif(&spira.ntuples.node_stb_data, "TPMREL");
>> +       if (!hdif_hdr) {
>> +               prlog(PR_INFO, "could not find TPMREL data\n");
> Make this PR_DEBUG or higher. Gating this entire function around
> proc_gen >= proc_gen_p9 might also be a good idea since this tuple
> will never be populated on P8 FSP systems so this is a nuisance
> warning there.

Good catch. I will gate that.

>> +               return;
>> +       }
>> +
>> +       /* TODO: Idata 0: Secure Boot and TPM Instance Info */
>> +       /* TODO: Idata 1: User Physical Interaction Mechanism Info */
>> +       /* TODO: Idata 2: Hash and Verification Function Offset Array */
>> +}
>> --
>> 2.7.4
>>
>> _______________________________________________
>> Skiboot mailing list
>> Skiboot at lists.ozlabs.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_skiboot&d=DwIBaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=75damxi8dv4vdGLwy_TNRoKm9_3FxQYCSDCtliSDIKc&m=srzWbN1CNe3nkNA26MGHhtCqfxwLG0s7MkdSflrrNKg&s=ePMbw9zE5RHH1jl0n6UnWIIhGVl_RXXhs4EdeFevYJI&e=