[Skiboot] [PATCH] p8-i2c: Further timeout reworks

Stewart Smith stewart at linux.vnet.ibm.com
Tue Oct 31 14:38:54 AEDT 2017

Oliver O'Halloran <oohall at gmail.com> writes:
> This patch reworks the way timeouts are set so that rather than imposing
> a hard deadline based on the transaction length it uses a
> kick-the-can-down-the-road approach where the timeout will be reset each
> time data is written to or received from the master. This fits better
> with the actual failure modes that timeouts are designed to handle, such
> as unusually slow or broken devices.
> Additionally this patch moves all the special case detection out of the
> timeout handler. This is help to improve the robustness of the driver and
> prepare for a more substantial rework of the driver as a whole later on.
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  hw/p8-i2c.c | 166 +++++++++++++++++++++++++++---------------------------------
>  1 file changed, 75 insertions(+), 91 deletions(-)

Thanks. Merged to master as of 7c154282947575d7478a3cda069095e4fbd7a632.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list