[Skiboot] [PATCH 1/9] phb4: Update comment

Michael Neuling mikey at neuling.org
Sat Oct 21 11:38:11 AEDT 2017


On Fri, 2017-10-20 at 14:54 +0200, Benjamin Herrenschmidt wrote:
> On Fri, 2017-10-20 at 22:59 +1100, Michael Neuling wrote:
> > No functional change.
> 
> Super critical comment...
> 
> > Signed-off-by: Michael Neuling <mikey at neuling.org>
> > ---
> >  hw/phb4.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/phb4.c b/hw/phb4.c
> > index c64ded92f9..492716857b 100644
> > --- a/hw/phb4.c
> > +++ b/hw/phb4.c
> > @@ -1140,7 +1140,7 @@ static int64_t phb4_ioda_reset(struct phb *phb, bool
> > purge)
> >  
> >  	/* Additional OPAL specific inits */
> >  
> > -	/* Clear RTT and PELTV */
> > +	/* Clear RTT and PELTV and pest */
> 
>  and PEST, not pest :-)

You're a pest! :-P

Mikey

> 
> >  	if (p->tbl_rtt)
> >  		memcpy((void *)p->tbl_rtt, p->rte_cache, RTT_TABLE_SIZE);
> >  	if (p->tbl_peltv)
> 
> 


More information about the Skiboot mailing list