[Skiboot] [PATCH] Revert "npu2: Add vendor cap for IRQ testing"

Stewart Smith stewart at linux.vnet.ibm.com
Wed Oct 18 09:00:15 AEDT 2017

Alistair Popple <alistair at popple.id.au> writes:
> This reverts commit 9817c9e29b6fe00daa3a0e4420e69a97c90eb373 which seems to
> break setting the PCI dev flag and the link number in the PCIe vendor
> specific config space. This leads to the device driver attempting to
> re-init the DL when it shouldn't which can cause HMI's.
> Signed-off-by: Alistair Popple <alistair at popple.id.au>
> ---
> Stewart, can we please get this merged soon? Ideally we should root cause why
> the original patch caused this issue as the IRQ testing could be useful if we
> ever get time to write tests, but I don't have bandwidth to debug it properly
> right now.
> Hopefully Sam might find some time to take a look, but for the moment a
> functioning DL flag is more important.
> - Alistair
> hw/npu2.c | 28 ----------------------------
>  1 file changed, 28 deletions(-)

No worries. Merged in as 1fdd66f270e5b270f5931b20af980001422044d6 and
merged into 5.9-rc3.

We can look at bringing it back later when root caused etc.

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list