[Skiboot] [PATCH] xive: Fix VP free block group mode false-positive parameter check

Stewart Smith stewart at linux.vnet.ibm.com
Mon Oct 16 19:06:25 AEDT 2017


Nicholas Piggin <npiggin at gmail.com> writes:
> The check to ensure the buddy allocation idx is aligned to its
> allocation order was not taking into account the allocation split.
> This would result in opal_xive_free_vp_block failures despite
> giving the same value as returned by opal_xive_alloc_vp_block.
>
> E.g., starting then stopping 4 KVM guests gives the following pattern
> in the host:
>
>   opal_xive_alloc_vp_block(5)=0x45000020
>   opal_xive_alloc_vp_block(5)=0x45000040
>   opal_xive_alloc_vp_block(5)=0x45000060
>   opal_xive_alloc_vp_block(5)=0x45000080
>   opal_xive_free_vp_block(0x45000020)=-1
>   opal_xive_free_vp_block(0x45000040)=0
>   opal_xive_free_vp_block(0x45000060)=-1
>   opal_xive_free_vp_block(0x45000080)=0
>
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>  hw/xive.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)


Thanks!

Merged to master as of a6559413f07d4bc6c58b00858c48d2fc70165011

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list