[Skiboot] [PATCH] FSP/NVRAM: Handle "get vNVRAM statistics" command

Stewart Smith stewart at linux.vnet.ibm.com
Wed Oct 11 07:34:18 AEDT 2017


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> FSP sends MBOX command (cmd : 0xEB, subcmd : 0x05, mod : 0x00) to get vNVRAM
> statistics. OPAL doesn't maintain any such statistics. Hence return
> FSP_STATUS_INVALID_SUBCMD.
>
> Sample OPAL log:
>   [16944.384670488,3] FSP: Unhandled message eb0500
>   [16944.474110465,3] FSP: Unhandled message eb0500
>   [16945.111280784,3] FSP: Unhandled message eb0500
>   [16945.293393485,3] FSP: Unhandled message eb0500
>
> With this patch, I don't think FSP will ever call "free vNVRAM" MBOX command.
> But to be safer side lets return FSP_STATUS_INVALID_SUBCMD for this MBOX
> command as well.
>
> Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  hw/fsp/fsp-nvram.c | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)

thanks,

merged to master as of 19d4f98e9483e4c1cae1d5a59491d8ab4f9a6e7f
and cherry-picked back to 5.4.x as of c17cec0fe9242689b888d50430ad9ed2abfe6529

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list