[Skiboot] [PATCH] pci-iov: free memory across fast-reboot

Stewart Smith stewart at linux.vnet.ibm.com
Wed Oct 11 07:28:57 AEDT 2017


Stewart Smith <stewart at linux.vnet.ibm.com> writes:
> pci_set_cap needs a callback to free data and we need to call
> that when we're doing __pci_reset()
>
> We also need to free pcrf entries.
>
> In the future, __pci_reset() and pci_remove_bus() need to come
> together to be one canonical place on how to free a PCI device
> rather than the two we have now. This patch *purely* focuses
> on the problem of not leaking memory across fast-reboot.
>
> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  core/pci-iov.c |  9 ++++++++-
>  core/pci.c     | 14 +++++++++++---
>  include/pci.h  |  9 +++++++--
>  3 files changed, 26 insertions(+), 6 deletions(-)

with this I've survived about 600 fast reboots on Habanero before the
BMC decided to go really far off to lunch. With those fast reboots, I
also checked that we weren't leaking any memory.

Merged as of 347e24521e87549f50ab049fc131567dd2d0ff92
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list