[Skiboot] [PATCH v2 1/4] FSP/CONSOLE: Do not associate unavailable console

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Oct 10 20:37:45 AEDT 2017


Presently OPAL sends associate/unassociate MBOX command for all
FSP serial console (like below OPAL message). We have to check
console is available or not before sending this message.

OPAL log:
-------
[ 5013.227994012,7] FSP: Reassociating HVSI console 1
[ 5013.227997540,7] FSP: Reassociating HVSI console 2

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
---
 hw/fsp/fsp-console.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c
index a855133..8ea4c16 100644
--- a/hw/fsp/fsp-console.c
+++ b/hw/fsp/fsp-console.c
@@ -92,6 +92,9 @@ static void fsp_console_reinit(void)
 	for (i = 0; i < MAX_SERIAL; i++) {
 		struct fsp_serial *fs = &fsp_serials[i];
 
+		if (!fs->available)
+			continue;
+
 		if (fs->rsrc_id == 0xffff)
 			continue;
 		prlog(PR_DEBUG, "FSP: Reassociating HVSI console %d\n", i);
@@ -903,6 +906,10 @@ static void reopen_all_hvsi(void)
 
  	for (i = 0; i < MAX_SERIAL; i++) {
 		struct fsp_serial *fs = &fsp_serials[i];
+
+		if (!fs->available)
+			continue;
+
 		if (fs->rsrc_id == 0xffff)
 			continue;
 		prlog(PR_NOTICE, "FSP: Deassociating HVSI console %d\n", i);
@@ -911,6 +918,10 @@ static void reopen_all_hvsi(void)
 	}
  	for (i = 0; i < MAX_SERIAL; i++) {
 		struct fsp_serial *fs = &fsp_serials[i];
+
+		if (!fs->available)
+			continue;
+
 		if (fs->rsrc_id == 0xffff)
 			continue;
 		prlog(PR_NOTICE, "FSP: Reassociating HVSI console %d\n", i);
-- 
2.9.3



More information about the Skiboot mailing list