[Skiboot] [PATCH] FSP: Disable PSI link whenever FSP tells OPAL about impending R/R
hegdevasant at linux.vnet.ibm.com
Mon Oct 9 17:03:59 AEDT 2017
On 10/09/2017 10:15 AM, Ananth N Mavinakayanahalli wrote:
> On Sat, Oct 07, 2017 at 03:10:32PM +0000, Vasant Hegde wrote:
>> Commit 42d5d047 fixed scenario where DPO has been initiated, but FSP went
>> into reset before the CEC power down came in. But this is generic issue
>> that can happen in normal shutdown path as well.
>> Hence disable PSI link as soon as we detect FSP impending R/R.
>> + /*
>> + * Its possible that the host has gone down, and OPAL is on
>> + * its way down and hence will not see the subsequent PSI
>> + * interrupt. So, just give up the link here.
>> + */
>> + psi_disable_link(psi);
>> + prlog(PR_NOTICE, "FSP #%d: FSP in Reset."
>> + " Waiting for PSI interrupt\n", fsp->index);
> The comment also needs fixing. If the FSP is already in reset, you may
> not get the PSI interrupt.
Ah! right. Will fix it in v2. Thanks.
More information about the Skiboot