[Skiboot] [PATCH] fsp: return OPAL_BUSY_EVENT on failure sending FSP_CMD_POWERDOWN_NORM

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sun Oct 8 01:53:47 AEDT 2017

On 10/02/2017 06:38 AM, Stewart Smith wrote:
> We had a race condition between FSP Reset/Reload and powering down
> the system from the host:


>  ::
> diff --git a/platforms/ibm-fsp/common.c b/platforms/ibm-fsp/common.c
> index 237b63fb4f05..0a9b06f77e33 100644
> --- a/platforms/ibm-fsp/common.c
> +++ b/platforms/ibm-fsp/common.c
> @@ -223,7 +223,7 @@ int64_t ibm_fsp_cec_power_down(uint64_t request)
>  	printf("FSP: Sending shutdown command to FSP...\n");

We may endup filling OPAL console with above message as kernel will repeatedly 
makes shutdown call.

>  	if (fsp_sync_msg(fsp_mkmsg(FSP_CMD_POWERDOWN_NORM, 1, request), true))

How about changing this to fsp_queue_msg?  Even in shutdown path we will be able 
to queue message and send it to FSP after R/R completes.


More information about the Skiboot mailing list