[Skiboot] [PATCH] ipmi: Convert common debug prints to trace

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sat Oct 7 04:32:40 AEDT 2017


OPAL logs messages for every IPMI request from host. Sometime OPAL console
is filled with only these messages. This path is pretty stable now and
we have enough logs to cover bad path. Hence lets convert these debug
message to trace/info message.

[ 1356.423958816,7] opal_ipmi_recv(cmd: 0xf0 netfn: 0x3b resp_size: 0x02)
[ 1356.430774496,7] opal_ipmi_send(cmd: 0xf0 netfn: 0x3a len: 0x3b)
[ 1356.430797392,7] BT: seq 0x20 netfn 0x3a cmd 0xf0: Message sent to host
[ 1356.431668496,7] BT: seq 0x20 netfn 0x3a cmd 0xf0: IPMI MSG done

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 core/ipmi-opal.c | 4 ++--
 hw/bt.c          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/core/ipmi-opal.c b/core/ipmi-opal.c
index 1b28aa6..d8df8f7 100644
--- a/core/ipmi-opal.c
+++ b/core/ipmi-opal.c
@@ -50,7 +50,7 @@ static int64_t opal_ipmi_send(uint64_t interface,
 		return OPAL_PARAMETER;
 	}
 
-	prlog(PR_DEBUG, "opal_ipmi_send(cmd: 0x%02x netfn: 0x%02x len: 0x%02llx)\n",
+	prlog(PR_TRACE, "opal_ipmi_send(cmd: 0x%02x netfn: 0x%02x len: 0x%02llx)\n",
 	       opal_ipmi_msg->cmd, opal_ipmi_msg->netfn >> 2, msg_len);
 
 	msg = ipmi_mkmsg(interface,
@@ -106,7 +106,7 @@ static int64_t opal_ipmi_recv(uint64_t interface,
 	opal_ipmi_msg->data[0] = msg->cc;
 	memcpy(&opal_ipmi_msg->data[1], msg->data, msg->resp_size);
 
-	prlog(PR_DEBUG, "opal_ipmi_recv(cmd: 0x%02x netfn: 0x%02x resp_size: 0x%02x)\n",
+	prlog(PR_TRACE, "opal_ipmi_recv(cmd: 0x%02x netfn: 0x%02x resp_size: 0x%02x)\n",
 	      msg->cmd, msg->netfn >> 2, msg->resp_size);
 
 	/* Add one as the completion code is returned in the message data */
diff --git a/hw/bt.c b/hw/bt.c
index 2f0726a..ce87e2b 100644
--- a/hw/bt.c
+++ b/hw/bt.c
@@ -270,7 +270,7 @@ static void bt_send_msg(struct bt_msg *bt_msg)
 	for (i = 0; i < ipmi_msg->req_size; i++)
 		bt_outb(ipmi_msg->data[i], BT_HOST2BMC);
 
-	BT_Q_DBG(bt_msg, "Message sent to host");
+	BT_Q_INF(bt_msg, "Message sent to host");
 	bt_msg->send_count++;
 
 	bt_outb(BT_CTRL_H2B_ATN, BT_CTRL);
@@ -362,7 +362,7 @@ static void bt_get_resp(void)
 		ipmi_msg->data[i] = bt_inb(BT_HOST2BMC);
 	bt_set_h_busy(false);
 
-	BT_Q_DBG(bt_msg, "IPMI MSG done");
+	BT_Q_INF(bt_msg, "IPMI MSG done");
 
 	list_del(&bt_msg->link);
 	bt.queue_len--;
-- 
2.9.3



More information about the Skiboot mailing list