[Skiboot] [PATCH] external/gard: Clear entire guard partition instead of entry by entry

Stewart Smith stewart at linux.vnet.ibm.com
Fri Oct 6 17:28:30 AEDT 2017


Suraj Jitindar Singh <sjitindarsingh at gmail.com> writes:
> When using the current implementation of the gard tool to ecc clear the
> entire GUARD partition it is done one gard record at a time. While this
> may be ok when accessing the actual flash this is very slow when done
> from the host over the mbox protocol (on the order of 4 minutes) because
> the bmc side is required to do many read, erase, writes under the hood.
>
> Fix this by rewriting the gard tool reset_partition() function. Now we
> allocate all the erased guard entries and (if required) apply ecc to the
> entire buffer. Then we can do one big erase and write of the entire
> partition. This reduces the time to clear the guard partition to on the
> order of 4 seconds.
>
> Reported-by: Pridhiviraj Paidipeddi <ppaidipe at linux.vnet.ibm.com>
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>

Merged to master as of b987d1a97632d19e50e1a4858408444c1ae01351
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list