[Skiboot] [PATCH] xscom: Do not print error message for 'chiplet offline' return values

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Oct 4 19:47:09 AEDT 2017


xscom_read/write operations returns CHIPLET_OFFLINE when chiplet is offline.
Some multicast xscom_read/write requests from HBRT results in xscom operation
on offline chiplet(s) and printing below warnings in OPAL console.

[ 135.036327572,3] XSCOM: Read failed, ret = -14
[ 135.092689829,3] XSCOM: Read failed, ret = -14

This results in unnecessary bugs.  Hence remove error message when
xscom_read/write return CHIPLET_OFFLINE.

Fixes: https://github.com/open-power/boston-openpower/issues/463
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/xscom.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/hw/xscom.c b/hw/xscom.c
index 7bd78bf..1c685a0 100644
--- a/hw/xscom.c
+++ b/hw/xscom.c
@@ -274,7 +274,9 @@ static int __xscom_read(uint32_t gcid, uint32_t pcb_addr, uint64_t *val)
 			break;
 	}
 
-	prerror("XSCOM: Read failed, ret =  %lld\n", ret);
+	if (ret != OPAL_XSCOM_CHIPLET_OFF)
+		prerror("XSCOM: Read failed, ret =  %lld\n", ret);
+
 	return ret;
 }
 
@@ -310,7 +312,9 @@ static int __xscom_write(uint32_t gcid, uint32_t pcb_addr, uint64_t val)
 			break;
 	}
 
-	prerror("XSCOM: Write failed, ret =  %lld\n", ret);
+	if (ret != OPAL_XSCOM_CHIPLET_OFF)
+		prerror("XSCOM: Write failed, ret =  %lld\n", ret);
+
 	return ret;
 }
 



More information about the Skiboot mailing list