[Skiboot] [PATCH RFC 1/2] phb4: Use read/write primitives when accessing PHB registers
Guilherme G. Piccoli
gpiccoli at linux.vnet.ibm.com
Wed Oct 4 01:01:29 AEDT 2017
On 10/03/2017 10:49 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2017-10-02 at 19:23 -0300, Guilherme G. Piccoli wrote:
>> Currently, the PHB registers access is mix-performed by the read/write
>> primitives or the open coded in/out procedures.
>> This patch change all open coded in/outs to use the read/write primitives.
>> No functional change is expected.
> It adds overhead for registers that are never going to be used via
> XSCOM in practice (what would be the point ?)
> If you get fenced during some of those init procedures you are pretty
> much a goner already. This looks like plaster on a wooden leg to me.
> Care to explain more what you are trying to achieve, it's not clear...
Patch 1 was more a code clean-up, but since it's adding overhead, let's
drop the entire series! Thanks a lot for the review!
More information about the Skiboot